whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed.
Because of the stability issues related to `getName()`-like constructs I'm putting a temporary ❌ on this (so it doesn't show up as faux accept). However, I have to emphasise that I do like the idea of the check! ================ Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:50 omp_gen + genconfusable ) ---------------- `gen_confusable_glyph_list`? ================ Comment at: clang-tools-extra/clang-tidy/misc/ConfusableTable/build_confusable_table.cpp:1 +//===--- build_confusable_table.cpp - clang-tidy---------------------------===// +// ---------------- Why does this file have `snake_case` name? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
