GuillaumeGomez added a comment.
I applied the changes suggested by @RKSimon and @efriedma.
================
Comment at: llvm/include/llvm/ADT/Triple.h:1031
/// @}
/// @name Static helpers for IDs.
/// @{
----------------
ldionne wrote:
> Comment applies to `test_demangle.pass.cpp` (it's a binary file so I can't
> comment on it). The test is currently failing because you need to change
> `_ZN4llvm9Intrinsic25getIntrinsicForClangBuiltinEPKcS2_` to
> `_ZN4llvm9Intrinsic27getIntrinsicForClangBuiltinEPKcS2_`.
You're right, I removed this change as it's unrelated.
================
Comment at: llvm/lib/IR/Function.cpp:1430
+// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method.
#define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN
#include "llvm/IR/IntrinsicImpl.inc"
----------------
GuillaumeGomez wrote:
> GuillaumeGomez wrote:
> > RKSimon wrote:
> > > Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN?
> > I think it should for coherency. I'll send an update.
> When replacing with `CLANG`, it cannot build. After some investigations, it's
> because of this:
>
> ```
> llvm/utils/TableGen/IntrinsicEmitter.cpp:908: OS << "#ifdef
> GET_LLVM_INTRINSIC_FOR_" << CompilerName << "_BUILTIN\n";
> ```
>
> So I'll let it as is for the time.
I fixed the error so it's now done. Thanks for the suggestion!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127460/new/
https://reviews.llvm.org/D127460
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
