GuillaumeGomez added inline comments.
================ Comment at: llvm/lib/IR/Function.cpp:1430 +// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method. #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN #include "llvm/IR/IntrinsicImpl.inc" ---------------- RKSimon wrote: > Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN? I think it should for coherency. I'll send an update. ================ Comment at: llvm/lib/IR/Function.cpp:1430 +// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method. #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN #include "llvm/IR/IntrinsicImpl.inc" ---------------- GuillaumeGomez wrote: > RKSimon wrote: > > Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN? > I think it should for coherency. I'll send an update. When replacing with `CLANG`, it cannot build. After some investigations, it's because of this: ``` llvm/utils/TableGen/IntrinsicEmitter.cpp:908: OS << "#ifdef GET_LLVM_INTRINSIC_FOR_" << CompilerName << "_BUILTIN\n"; ``` So I'll let it as is for the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
