cor3ntin added inline comments.
================
Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:49
+ std::string s;
+ s.reserve(64);
+ auto n = this;
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > Any particular reason for 64?
> Still wondering why 64 bytes specifically.
It's semi arbitrary (aka a nice power of two that fits in a cacheline) - but
it's large enough that it fits the 99% of names (the 99th percentile is
actually around 46 byte)
================
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:17-18
+// List of generated names
+// Should be kept in sync with Unicode
+// "Name Derivation Rule Prefix String".
+static bool generated(char32_t c) {
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > Do we have something more direct to point users towards?
> Unanswered question here. May be a good place for a link like Tom had
> mentioned.
This comment should no longer apply as I got rid of the `generated` method -
instead only relying on info we find when parsing the file (see line 44).
It doesn't mean that we don't need more reference to the UnicodeData.txt url
though
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123064/new/
https://reviews.llvm.org/D123064
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
