abrachet marked 5 inline comments as done. abrachet added a comment. In D109977#3558762 <https://reviews.llvm.org/D109977#3558762>, @MaskRay wrote:
> Thanks for picking up the change. I confirm that I can build `llvm` without > an error and it appears to work fine. > >> llvm-driver can be disabled from builds by setting >> LLVM_TOOL_LLVM_DRIVER_BUILD=Off. > > I think this should be opt-in. The new `llvm` executable takes a lot of space > and not needed by many developers/build bots. > It's useful to some groups (distributions) but they can specify the option > themselves. > I think the modified code is quite stable, so don't worry about regressions > just because this is not opt-in. I didn't update the commits message, now it properly says that it can be opted in by setting `LLVM_TOOL_LLVM_DRIVER_BUILD` to `On` In D109977#3558768 <https://reviews.llvm.org/D109977#3558768>, @MaskRay wrote: > % /tmp/out/custom1/bin/llvm --help > ... The output now looks like: OVERVIEW: llvm toolchain driver USAGE: llvm [subcommand] [options] SUBCOMMANDS: ar clang dsymutil cxxfilt objcopy ranlib lib dlltool clang++ clang-cl clang-cpp install-name-tool bitcode-strip strip Type "llvm <subcommand> --help" to get more help on a specific subcommand OPTIONS: --help - Display this message What do you think? ================ Comment at: llvm/tools/llvm-driver/llvm-driver.cpp:50 + bool ConsumeFirstArg = false; + if (LaunchedTool == "llvm") { + if (Argc < 2) ---------------- MaskRay wrote: > Some distributions may want to use something like llvm-15. See some binary > utilities how the version is handled. Thank's I've taken this from objcopy's code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
