abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments.
================ Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:488-490 + `private_var`, `firstprivate_var`, and `lastprivate_var` arguments are + variadic list of operands that specify the data sharing attributes of the + list of values ---------------- shraiysh wrote: > If they are not added, please remove them from documentation too. It would be > misleading otherwise. Ok ================ Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:528 + + let regions = (region AnyRegion:$region); +} ---------------- shraiysh wrote: > I think we need a verifier for this too. There are a couple semantic checks > which we can do in verifier. Can you say more about the semantic checks you have in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
