jansvoboda11 added a comment. This looks good IMO. Let's see if others have more suggestions besides the `Parser`/`Sema` layering.
================ Comment at: clang/lib/Parse/ParseObjc.cpp:16 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetInfo.h" ---------------- vsapsai wrote: > I'd like to get feedback on Parser/Sema layering. I'll check myself what can > be done but at the first glance accessing pieces of Sema from Parser looks > questionable. Yeah, I think introducing new `Sema::ActOnEndClassInterface()` and moving the diagnostic logic there might be cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://reviews.llvm.org/D124286 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
