vsapsai added a comment. I also have a very similar change with `ActOnDuplicateDefinition` for `ObjCProtocolDecl`. If anybody is interested in how it compares with `ObjCInterfaceDecl`, I can publish that but it's not finished yet.
================ Comment at: clang/lib/Parse/ParseObjc.cpp:16 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetInfo.h" ---------------- I'd like to get feedback on Parser/Sema layering. I'll check myself what can be done but at the first glance accessing pieces of Sema from Parser looks questionable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://reviews.llvm.org/D124286 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
