upsj marked 2 inline comments as done.
upsj added inline comments.
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:195
+ // Build Inlay Hints for the entire AST
+ bool buildInlayHints(llvm::Optional<Range> LineRange) {
----------------
nridge wrote:
> The comment should probably say "... for the entire AST or the specified
> range"
done
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:201
+ for (const auto &Hint : Hints) {
+ vlog(" {0} {1}", Hint.position, Hint.label);
+ }
----------------
nridge wrote:
> Might be useful for print the hint kind as well?
right, is the current solution (adding a public toString) okay?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124344/new/
https://reviews.llvm.org/D124344
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
