upsj created this revision.
upsj added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
upsj requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
With the addition of inlay hints to clangd, it would be useful to output them
during verbose `clangd --check`.
This patch adds an output step for inlay hints and unifies the way
`--check-lines` are passed around
https://reviews.llvm.org/D124344
Files:
clang-tools-extra/clangd/tool/Check.cpp
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===================================================================
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -61,8 +61,7 @@
namespace clangd {
// Implemented in Check.cpp.
-bool check(const llvm::StringRef File,
- llvm::function_ref<bool(const Position &)> ShouldCheckLine,
+bool check(const llvm::StringRef File, llvm::Optional<Range> LineRange,
const ThreadsafeFS &TFS, const ClangdLSPServer::Options &Opts,
bool EnableCodeCompletion);
@@ -955,8 +954,9 @@
return 1;
}
log("Entering check mode (no LSP server)");
- uint32_t Begin = 0, End = std::numeric_limits<uint32_t>::max();
+ llvm::Optional<Range> CheckLineRange;
if (!CheckFileLines.empty()) {
+ uint32_t Begin = 0, End = std::numeric_limits<uint32_t>::max();
StringRef RangeStr(CheckFileLines);
bool ParseError = RangeStr.consumeInteger(0, Begin);
if (RangeStr.empty()) {
@@ -965,19 +965,18 @@
ParseError |= !RangeStr.consume_front("-");
ParseError |= RangeStr.consumeInteger(0, End);
}
- if (ParseError || !RangeStr.empty()) {
- elog("Invalid --check-line specified. Use Begin-End format, e.g. 3-17");
+ if (ParseError || !RangeStr.empty() || Begin <= 0 || End < Begin) {
+ elog(
+ "Invalid --check-lines specified. Use Begin-End format, e.g. 3-17");
return 1;
}
+ CheckLineRange = Range{Position{static_cast<int>(Begin - 1), 0},
+ Position{static_cast<int>(End), 0}};
}
- auto ShouldCheckLine = [&](const Position &Pos) {
- uint32_t Line = Pos.line + 1; // Position::line is 0-based.
- return Line >= Begin && Line <= End;
- };
// For now code completion is enabled any time the range is limited via
// --check-lines. If it turns out to be to slow, we can introduce a
// dedicated flag for that instead.
- return check(Path, ShouldCheckLine, TFS, Opts,
+ return check(Path, CheckLineRange, TFS, Opts,
/*EnableCodeCompletion=*/!CheckFileLines.empty())
? 0
: static_cast<int>(ErrorResultCode::CheckFailed);
Index: clang-tools-extra/clangd/tool/Check.cpp
===================================================================
--- clang-tools-extra/clangd/tool/Check.cpp
+++ clang-tools-extra/clangd/tool/Check.cpp
@@ -30,8 +30,10 @@
#include "Config.h"
#include "GlobalCompilationDatabase.h"
#include "Hover.h"
+#include "InlayHints.h"
#include "ParsedAST.h"
#include "Preamble.h"
+#include "Protocol.h"
#include "SourceCode.h"
#include "XRefs.h"
#include "index/CanonicalIncludes.h"
@@ -190,10 +192,20 @@
return true;
}
+ // Build Inlay Hints for the entire AST
+ bool buildInlayHints(llvm::Optional<Range> LineRange) {
+ log("Building inlay hints");
+ auto Hints = inlayHints(*AST, LineRange);
+
+ for (const auto &Hint : Hints) {
+ vlog(" {0} {1}", Hint.position, Hint.label);
+ }
+ return true;
+ }
+
// Run AST-based features at each token in the file.
- void testLocationFeatures(
- llvm::function_ref<bool(const Position &)> ShouldCheckLine,
- const bool EnableCodeCompletion) {
+ void testLocationFeatures(llvm::Optional<Range> LineRange,
+ const bool EnableCodeCompletion) {
trace::Span Trace("testLocationFeatures");
log("Testing features at each token (may be slow in large files)");
auto &SM = AST->getSourceManager();
@@ -207,7 +219,7 @@
unsigned End = Start + Tok.length();
Position Pos = offsetToPosition(Inputs.Contents, Start);
- if (!ShouldCheckLine(Pos))
+ if (LineRange && LineRange->contains(Pos))
continue;
trace::Span Trace("Token");
@@ -254,8 +266,7 @@
} // namespace
-bool check(llvm::StringRef File,
- llvm::function_ref<bool(const Position &)> ShouldCheckLine,
+bool check(llvm::StringRef File, llvm::Optional<Range> LineRange,
const ThreadsafeFS &TFS, const ClangdLSPServer::Options &Opts,
bool EnableCodeCompletion) {
llvm::SmallString<0> FakeFile;
@@ -282,9 +293,9 @@
: /*Don't turn on local configs for an arbitrary temp path.*/ ""));
Checker C(File, Opts);
if (!C.buildCommand(TFS) || !C.buildInvocation(TFS, Contents) ||
- !C.buildAST())
+ !C.buildAST() || !C.buildInlayHints(LineRange))
return false;
- C.testLocationFeatures(ShouldCheckLine, EnableCodeCompletion);
+ C.testLocationFeatures(LineRange, EnableCodeCompletion);
log("All checks completed, {0} errors", C.ErrCount);
return C.ErrCount == 0;
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
