fhahn added a comment.

In D122983#3464331 <https://reviews.llvm.org/D122983#3464331>, @xbolva00 wrote:

> In D122983#3464315 <https://reviews.llvm.org/D122983#3464315>, @aaron.ballman 
> wrote:
>
>> In D122983#3463561 <https://reviews.llvm.org/D122983#3463561>, @MaskRay 
>> wrote:
>>
>>> Adding a global `-Wno-implicit-function-declaration` looks good. @Meinersbur
>>
>> +1 to this idea, but I'm worried it won't fix that particular bot.
>
> You probably need to fix Makefiles as well. I believe there were similar 
> mysterious errors with -ffp-contract changes. Try to look at history of llvm 
> test-suite.
>
> cc @fhahn if he can remember more

Depending on how many tests need updating in llvm-test-suite, I think it would 
be better to only disable the warning per-test, after verifying the warning 
works as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122983/new/

https://reviews.llvm.org/D122983

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to