xbolva00 added a subscriber: fhahn. xbolva00 added a comment. In D122983#3464315 <https://reviews.llvm.org/D122983#3464315>, @aaron.ballman wrote:
> In D122983#3463600 <https://reviews.llvm.org/D122983#3463600>, @nemanjai > wrote: > >> In D122983#3463569 <https://reviews.llvm.org/D122983#3463569>, @xbolva00 >> wrote: >> >>> But your link shows failures in compiler-rt/, not in llvm test-suite >> >> It shows both. But the `compiler-rt` ones have subsequently been fixed while >> the `test-suite` ones are still failing as of >> https://lab.llvm.org/buildbot/#/builders/105/builds/24314. > > Thanks for pointing this out -- I'm baffled what's going on with that bot, > because 1) other bots running the test suite are fine, and 2) the test suite > was already fixed to disable the diagnostics (which is what fixed things for > #1): > > https://github.com/llvm/llvm-test-suite/blob/main/MultiSource/Benchmarks/Prolangs-C/archie-client/CMakeLists.txt#L2 > https://github.com/llvm/llvm-test-suite/blob/main/MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt#L1 > > (and so on). It's almost as if something on that particular bot is overriding > the cmake flags (or perhaps using CFLAGS instead of CPPFLAGS)... Here's the > command line that's failing for bison's symtab.c: > > RunSafely.sh detected a failure with these command-line arguments: > --show-errors -t > /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/test/sandbox/build/tools/timeit > 500 /dev/null Output/symtab.llvm.o.compile > /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/stage1.install/bin/clang > > -I/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/test/sandbox/build/MultiSource/Benchmarks/Prolangs-C/bison > > -I/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/test/test-suite/MultiSource/Benchmarks/Prolangs-C/bison > > -I/home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/test/test-suite/include > -I../../../../include -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -DNDEBUG -O3 > -ffp-contract=off -fomit-frame-pointer -c > /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/test/test-suite/MultiSource/Benchmarks/Prolangs-C/bison/symtab.c > -o Output/symtab.llvm.o > > Note how it's missing the warning flag from the CMakeLists.txt file. > > So I have no idea what's going on (I can't even really run the tests; I'm on > Windows and test-suite requires perl to run). > > In D122983#3463561 <https://reviews.llvm.org/D122983#3463561>, @MaskRay wrote: > >> Adding a global `-Wno-implicit-function-declaration` looks good. @Meinersbur > > +1 to this idea, but I'm worried it won't fix that particular bot. You probably need to fix Makefiles as well. I believe there were similar mysterious errors with -ffp-contract changes. Try to look at history of llvm test-suite. cc @fhahn if he can remember more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
