rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Sure, this serves as a reminder that you should always convert from UTF-8 to wide in Windows support code. I still think we should always explicitly call the wide variants, and it seems like you agree. Defining these macros is just a way to ensure we don't accidentally regress. Can you build asan with this change? I suspect it will be sensitive to it because it wraps the win32 API directly rather than going through Support. http://reviews.llvm.org/D21643 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
