dblaikie added a comment.

In D121328#3405623 <https://reviews.llvm.org/D121328#3405623>, @deansturtevant 
wrote:

> Aha! (I think).
> If the code to test "isExternalVisible" is executed *after* the code to test 
> whether it's a C++ member function (the very next test), then the problem 
> wouldn't arise.

Oh, fair - good call. Updated with that change & it does address the warning 
issue. Added a regression test for that too (not sure if there are other cases 
worth covering too... nothing that springs to mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121328/new/

https://reviews.llvm.org/D121328

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to