aaron.ballman added a comment. > once we figure out what to do about the change in behavior for > -Wnon-c-typedef-for-linkage
The devil is in the details; I'm not sure what to do here. I don't think there's a way to compute the visibility without also computing the linkage, so I don't think there's a way to get the old behavior in the Chrome OS case as well as suppressing the diagnostic in the case you want to cover. I'm sympathetic to the issue, but this may be a case where it's a matter of picking which behavior is more important because we may not be able to have both (at least, not without work to tease apart linkage and visibility if that's possible). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
