iains marked an inline comment as done.
iains added inline comments.

================
Comment at: clang/test/Modules/cxx20-multiple-partitions.cpp:48
+#else
+#error "no TU set"
+#endif
----------------
jansvoboda11 wrote:
> Instead of splitting the file with preprocessor, you could use the 
> `split-file` utility (introduced in D83834).
thanks!
this is exactly what is needed here.
I've converted the added cases here (and will do for the follow-on patches).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118586/new/

https://reviews.llvm.org/D118586

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to