urnathan added inline comments.
================
Comment at: clang/include/clang/Basic/Module.h:520-522
+ /// Get the primary module interface name from a partition.
+
+ std::string getPrimaryModuleInterfaceName() const {
----------------
stray blank line?
================
Comment at: clang/include/clang/Basic/Module.h:523-524
+ std::string getPrimaryModuleInterfaceName() const {
+ std::string::size_type pos = Name.find(':');
+ if (pos == std::string::npos)
+ return Name;
----------------
haven't you added an IsPartition flag to Module? can't you test that before
searching? Also, Almost Always Auto?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118598/new/
https://reviews.llvm.org/D118598
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
