nikic added inline comments.
================ Comment at: clang/lib/CodeGen/Address.h:30 + // Int portion stores lower 3 bits of the log of the alignment. + llvm::PointerIntPair<llvm::Type *, 3, unsigned> ElementType; ---------------- Are we guaranteed 3 bits even on 32-bit architectures? ================ Comment at: clang/lib/CodeGen/Address.h:45 + auto AlignLog = llvm::Log2_64(alignment.getQuantity()); + assert(AlignLog < (1 << 6) && "cannot fit alignment into 6 bits"); + Pointer.setInt(AlignLog >> 3); ---------------- Why can we assume this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
