JackAKirk added a comment. In D118023#3266877 <https://reviews.llvm.org/D118023#3266877>, @tra wrote:
> LGTM. Should I commit the patch on your behalf? > > In D118023#3265601 <https://reviews.llvm.org/D118023#3265601>, @JackAKirk > wrote: > >> Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the >> correct value already but didn't seem to cover the mistake. > > It appears that we do not actually test for the correct number of registers > used in an instruction argument, only for the correct instruction variant > itself. > It should've been caught if we were to attempt assembling generated PTX with > ptxas. Thanks I can try to land it myself. I executed `arc land` and it is asking me to "Land these changes". I am not sure that I have the permissions for this to succeed, but I can try. I have not done this before: is it safe to enter simply "y" with the existing commit message (name/email in the commit are correct)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
