tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM. Should I commit the patch on your behalf? In D118023#3265601 <https://reviews.llvm.org/D118023#3265601>, @JackAKirk wrote: > Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct > value already but didn't seem to cover the mistake. It appears that we do not actually test for the correct number of registers used in an instruction argument, only for the correct instruction variant itself. It should've been caught if we were to attempt assembling generated PTX with ptxas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
