carlosgalvezp added a comment.

Code looks great! Would it be worth mentioning the change in the release notes? 
I also wonder if the check documentation needs some updates. From what i read 
in the discussion this rule has poor enforcement in the guidelines so perhaps 
it's good to clarify what exactly the check covers. I'm afk right now so i 
can't check this in detail :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116386/new/

https://reviews.llvm.org/D116386

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to