LegalizeAdulthood added a comment.

Also, re-reading the C++ guidelines, I agree that this check is handling the 
two cases
ES.31 (Don't use macros for constants and functions)
ES.33 (Don't use macros that aren't all caps)

I guess previously it **technically** handled ES.30 (don't use macros for text 
manipulation)
by just complaining about every macro not being replaced with a `constexpr` 
constant,
LOL.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116386/new/

https://reviews.llvm.org/D116386

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to