craig.topper added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:353 + +multiclass VIndexLoadStore<list<int> EEWList> { + foreach n = EEWList in { ---------------- Why is this class only used for [64] ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:821 -let Predicates = [HasStdExtV, IsRV64] in { - // Vector Indexed Instructions ---------------- craig.topper wrote: > Is this deletion correct? I don't see where the VLUXEI64 instructions are > declared now. Oh I see, it's done with `VIndexLoadStore<[64]>`. ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:893 +// Vector Indexed Instructions +defm "" : VIndexLoadStore<[64]>; ---------------- EEW64 indexed loads/stores also require RV64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits