sepavloff added inline comments.

================
Comment at: clang/docs/UsersManual.rst:920
 
+To generate paths relative to the configuration file, the `<@>` token may be
+used. This will expand to the absolute path of the directory containing the
----------------
Response and configuration files are different things, so the documentation 
must more specific what facility is extended.

According to this implementation the response file treatment is extended. 
During development of configuration files couple of attempts were taken to 
extend the functionality of response files (see for example 
https://reviews.llvm.org/D36045). They were rejected as breaking compatibility 
with gcc. It does not mean that such extending is not possible, but it should 
be discussed in wider community. There must be serious reason for such 
extension and significant use case.

As for using this feature for configuration files, it does not look as very 
helpful. Configuration files are searched for in several places and the first 
found file is used. In this case specification of various locations relative to 
the config-file does not look neither safe nor natural. Specific use case also 
would be helpful to ground the need for such extension.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115604/new/

https://reviews.llvm.org/D115604

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to