junaire added a comment. In D115231#3194372 <https://reviews.llvm.org/D115231#3194372>, @RKSimon wrote:
> Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well > in the same patch since they are very similar? Hi, thanks for take a look at this. Yes, you're right. The reason I split them is that I'm a beginner, so I want to send a "experimental patch" first, this will make review work a little bit easier if I mess something up. I think it's reasonable to add all similar builtins if currently nothing wrong about this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
