fhahn added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:2116
+
+ // __builtin_reduce_xor restricts the element type to vector of integers type
+ // only.
----------------
nit: the element type will be restricted to `int`, so maybe say something like
`only supports vectors of integers`>
================
Comment at: clang/test/Sema/builtins-reduction-math.c:50
+ i = __builtin_reduce_xor(i);
+ // expected-error@-1 {{1st argument must be a vector of integers type (was
'int')}}
+
----------------
`vector of integers type` sounds a bit off. Not sure if that's much better, but
how about dropping the `type` from the end?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115231/new/
https://reviews.llvm.org/D115231
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
