craig.topper added inline comments.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782
+ if (IsZvlExt) {
+ ExtName.consume_back("b");
+ unsigned ZvlLen;
----------------
craig.topper wrote:
> I think we should check the return value from consume_back and getAsInteger
> to make sure we really parsed what we think we parsed. That will prevent
> surprises if a new extension comes along that also starts with "zvl"
This would match for "zvlsseg" right now wouldn't it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
