craig.topper added inline comments.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:739
static constexpr ImpliedExtsEntry ImpliedExts[] = {
- {{"v"}, {ImpliedExtsV}},
- {{"zfh"}, {ImpliedExtsZfh}},
+ {"v", {ImpliedExtsV}},
+ {"zfh", {ImpliedExtsZfh}},
----------------
Need curly braces around the strings too.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:805
+ unsigned ZvlLen = 0;
+ ExtName.getAsInteger(10, ZvlLen);
+ MinVLen = std::max(MinVLen, ZvlLen);
----------------
getAsInteger returns an indication of success or failure. We should check that
too. That will protect us in case someone creates an extension like "zvlfoob"
in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
