MyDeveloperDay added inline comments.
================
Comment at: compiler-rt/lib/lsan/lsan.h:20
+#elif SANITIZER_WINDOWS
+# include "lsan_win.h"
#endif
----------------
MyDeveloperDay wrote:
> clemenswasser wrote:
> > vitalybuka wrote:
> > > clemenswasser wrote:
> > > > MyDeveloperDay wrote:
> > > > > clang-format?
> > > > Yes, this is caused by clang-format. What should I do about it?
> > > @clemenswasser Can you please a separate tiny patch which clang-format
> > > nearby lines
> > @vitalybuka Should I create a patch, where I format the whole file or just
> > these `#include`s?
> Sorry, is there a reason we can't follow the current style in this patch?
> sorry did I miss something? Its not about fighting clang-format its about
> ensuring we follow the style from the lines around it which are following the
> clang-format style. I don't need you to clang-format the whole file (although
> that would be great because this directory has very low clang-format status)
>
> {F20932130, size=full}
> https://clang.llvm.org/docs/ClangFormattedStatus.html
>
> All I'm asking is that we don't indent the preprocessor directives to a non
> LLVM style.
>
> i.e.
>
> ```
> #include "lsan_win.h"
> #if !SANITIZER_WINDOWS
> #endif
> ```
>
> vs
>
> ```
> # include "lsan_win.h"
> # if !SANITIZER_WINDOWS
> # endif
> ```
You can ignore my comment, whilst I think the lsan .clang-format file is
incorrect in terms of matching the LLVM style it is correct from the lsan
subprojects point of view. I see now that you are doing what is in the local
.clang-format file and its the rest of the file is incorrect. (you would handle
that separately or not at all)
The fact that the .clang-format file doesn't follow the LLVM style is
unfortunate, but as I expressed thats upto you all.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115103/new/
https://reviews.llvm.org/D115103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
