MyDeveloperDay added inline comments.
================
Comment at: compiler-rt/lib/lsan/lsan.h:20
+#elif SANITIZER_WINDOWS
+# include "lsan_win.h"
#endif
----------------
vitalybuka wrote:
> MyDeveloperDay wrote:
> > clang-format?
> @clemenswasser Can you please a separate tiny patch which clang-format
> nearby lines
Sorry, is there a reason we can't follow the current style in this patch? sorry
did I miss something? Its not about fighting clang-format its about ensuring
we follow the style from the lines around it which are following the
clang-format style. I don't need you to clang-format the whole file (although
that would be great because this directory has very low clang-format status)
{F20932130, size=full}
https://clang.llvm.org/docs/ClangFormattedStatus.html
All I'm asking is that we don't indent the preprocessor directives to a non
LLVM style.
i.e.
```
#include "lsan_win.h"
#if !SANITIZER_WINDOWS
#endif
```
vs
```
# include "lsan_win.h"
# if !SANITIZER_WINDOWS
# endif
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115103/new/
https://reviews.llvm.org/D115103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
