aaron.ballman added a comment. In D108560#3167912 <https://reviews.llvm.org/D108560#3167912>, @salman-javed-nz wrote:
> In D108560#3167883 <https://reviews.llvm.org/D108560#3167883>, @aaron.ballman > wrote: > >> In D108560#3167847 <https://reviews.llvm.org/D108560#3167847>, >> @salman-javed-nz wrote: >> >>> If the current code stayed in the main repo, how long could you afford to >>> wait for me to provide a patch? >> >> I would say that for me personally, at a maximum, we have to either fix or >> revert before this goes out in a release of Clang (because Clang 13 did not >> have support for NOLINTBEGIN/NOLINTEND, so this is technically unreleased >> functionality). > > I see. Under normal circumstances, which release would this patch be going > into? Clang 14, not the next 13 point release, right? Correct! Our point releases don't add new features, they only cherry-pick bug fixes. So if NOLINTBEGIN did land in Clang 13, then the fix could potentially be a good one for Clang 13.0.1. But because NOLINTBEGIN didn't make it to Clang 13, Clang 14 will be the first release exposing the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108560/new/ https://reviews.llvm.org/D108560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
