kyulee added inline comments.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:851
+      addString(AnnotationDie, dwarf::DW_AT_const_value, Value->getString());
+    else if (const auto *Expr = dyn_cast<DIExpression>(ValueOp))
+      addConstantValue(
----------------
It checks an expression but appears to apply the constant case below. Should it 
check a constant expression, instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114565/new/

https://reviews.llvm.org/D114565

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to