kyulee added inline comments.
================
Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:273
- if (!DataSize)
+ if (!CountersSize)
return 0;
----------------
Is it no diff change? I wonder if there is a case where `CountersSize` is 0 but
not `DataSize` from a value probe.
If not, should we make a separate change?
================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:647
+ PD.NumValueSites[ValueKind] =
+ std::max(PD.NumValueSites[ValueKind], (uint32_t)(Index + 1));
}
----------------
It appears this is a NFC. Should we make a separate change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114565/new/
https://reviews.llvm.org/D114565
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
