tbaeder marked 13 inline comments as done. tbaeder added inline comments.
================ Comment at: clang/test/Driver/plugin-driver-args.cpp:11 +// Dashes cannot be part of the plugin name here +// RUN: %clang -fplugin=%llvmshlibdir/CallSuperAttr%pluginext -fplugin-arg-call_super_plugin-help-long -fsyntax-only %s 2>&1 -### | FileCheck %s --check-prefix=CHECK-CMD +// CHECK-CMD: "-plugin-arg-call_super_plugin" "help-long" ---------------- MaskRay wrote: > I assume that you have checked `// REQUIRES: plugins, examples` is not > needed, i.e. the test still passes if -DLLVM_ENABLE_PLUGINS=off I did, but I didn't delete the local `CallSuperAttr.so`. After doing that, they failed. I hope using `-###` as well here is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
