MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
The idea LGTM. You need a test in `test/Driver` checking how the driver option
maps to the CC1 option.
You may check whether `REQUIRES: plugins, examples` is needed.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6625
+ auto ArgValue = StringRef(A->getValue());
+ auto FirstDashIndex = ArgValue.find('-');
+ auto Arg = ArgValue.substr(FirstDashIndex + 1);
----------------
What if FirstDashIndex == std::string::npos?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113250/new/
https://reviews.llvm.org/D113250
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
