aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a nit with naming/wording. Feel free to land without additional review (unless you want more review, of course!).
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9868-9869 InGroup<IgnoredAttributes>; +def err_duplicate_attribute : Error< + "attribute %0 cannot appear more than once on a declaration">; ---------------- We typically don't use distinct wording for `err_foo` and `warn_foo` diagnostics -- folks tend to assume they've got the same wording and the only difference is the severity. Potential ways forward: * Rename to `err_duplicate_attribute_exact` and use the same wording as the warning version) * Leave wording alone, rename to something else (perhaps `err_repeated_multiversion_attribute`) to make it specific to this usage I don't insist on a particular path (or a change at all, if you have strong attachment), but I think it'd be nice to fix it before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
