danielkiss accepted this revision.
danielkiss added a comment.
This revision is now accepted and ready to land.

In D51650#3121789 <https://reviews.llvm.org/D51650#3121789>, @erichkeane wrote:

> But nit made.

NIT: clang-format issues still present. Maybe you need to update your local 
clang-format.

In D51650#3121789 <https://reviews.llvm.org/D51650#3121789>, @erichkeane wrote:

> For the rest of multiversioning we count on the optimizer to remove variants 
> made irrelevant, but I'm not sure opt can do anything like that yet :)

I think removing the duplicated in opt is harder than just eliminate them here. 
At the end maybe the function does not need ifunc.

LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51650/new/

https://reviews.llvm.org/D51650

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to