jansvoboda11 added inline comments.
================
Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1
-[
- {
- "directory": "DIR",
- "command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4
-I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules
-fmodules-cache-path=DIR/module-cache -fimplicit-modules
-fmodule-map-file=DIR/module.modulemap",
- "file": "DIR/header-search-pruning.cpp"
- }
-]
+[{
+ "directory" : "DIR",
----------------
Please undo the whitespace changes in `ClangScanDeps` tests.
================
Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3
+ "directory" : "DIR",
+ "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4
-I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fmodules-cache-path=DIR/module-cache
-fimplicit-modules -fmodule-map-file=DIR/module.modulemap",
+ "file" : "DIR/header-search-pruning.cpp"
----------------
Can you explain why `-fcxx-modules` is removed? We want to explicitly enable
Clang modules for C++ inputs here. That's off by default in our downstream repo
and we'd like to keep this upstream to prevent conflicts. (it's benign upstream)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113391/new/
https://reviews.llvm.org/D113391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
