erichkeane added a subscriber: Fznamznon. erichkeane added a comment. @Fznamznon was into this a bunch at once, so she should probably take a look as well.
================ Comment at: clang/lib/Sema/Sema.cpp:1936 + if (LangOpts.SYCLIsDevice || (LangOpts.OpenMP && LangOpts.OpenMPIsDevice)) + CheckDeviceType(Ty); + ---------------- Should this be a return, or do we still intend the device invocations to go through the below checks too? If so, please write a test for that. ================ Comment at: clang/lib/Sema/SemaDecl.cpp:9573 - checkTypeSupport(NewFD->getType(), D.getBeginLoc(), NewFD); + if (D.getFunctionDefinitionKind() != FunctionDefinitionKind::Declaration) + checkTypeSupport(NewFD->getType(), D.getBeginLoc(), NewFD); ---------------- Why are we not checking declarations here? This doesn't seem right to me. At least in the offload languages, we still need to check declarations. Also, if something is a problem with a declaration, why is it not a problem with defaulted/deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
