craig.topper added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCV.td:182
 
+def FeatureExtZve32x
+    : SubtargetFeature<"experimental-zve32x", "HasStdExtZve32x", "true",
----------------
frasercrmck wrote:
> Do we need to define distinct `SubtargetFeature`s for each of these 
> extensions or could they be broken down into a single `MaxEEW` feature (32 or 
> 64) in conjunction with the pre-existing F/D features. This seems like it's 
> more complicated than it needs to be.
I don't think it is quite that simple. Couldn't you have a scalar D and have 
zve64f vector?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112408/new/

https://reviews.llvm.org/D112408

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to