rjmccall added inline comments.
================
Comment at: clang/test/SemaCXX/PR51855.cpp:71
+// CHECK: call void @_ZN1S4putMEs
+// CHECK: call {{(signext )?i16}} @_ZN1S4getMEv
----------------
rnk wrote:
> Please add test coverage for the interesting operators in the code under
> edit: OO_Subscript, OO_Arrow, OO_Amp. Please also add equivalent coverage to
> the ObjC test cases, or give me a link to show that it's already covered.
>
> Maybe OO_Amp is unnecessary, I'm not sure how it is supposed to work for
> psuedo objects.
Different pseudo-object extensions can define their own rules for different
syntactic use patterns, but currently there aren't any that have special
treatment for either unary or binary `&`; you just take the default "r-value"
path and then see if you can apply the operator to the result.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111639/new/
https://reviews.llvm.org/D111639
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
