keith added inline comments.
================ Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) + ExternalFS->setCurrentWorkingDirectory(Path); + ---------------- JDevlieghere wrote: > I'm pretty sure there was a reason we stopped doing this. There should be > some discussion about that in my original patch. So it sounds like it was related to this: > [fallthrough] ... but not for relative paths that would get resolved > incorrectly at the lower layer (for example, in case of the RealFileSystem, > because the strictly virtual path does not exist). But if I remove that 2 of my new tests `ReturnsInternalPathVFSHit` and `ReturnsExternalPathVFSHit` do not pass. I think the behavior of them is what we want, what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
