keith added a comment. Ok I've updated the diff here based on @dexonsmith's original suggestion, and some offline discussion with @JDevlieghere
The new logic remaps the files and statuses, in the fallback to the external FS case, to use the originally requested path. I opted not to use the second suggestion with passing the `struct` containing both paths through because of the churn that would have on the API to maintain the current public signatures while also supporting that. This approach is analogous to how we're currently remapping the statuses for `use-external-names` as well. Please let me know what you think! Note there's some churn from me renaming `Path` -> `CanonicalPath` and `Path_` -> `OriginalPath`, let me know if you'd prefer I extract this into a separate diff that we land first without any logic changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
