FreddyYe marked an inline comment as done.
FreddyYe added a comment.
Sorry for late response. Thanks for your comments, @DavidSpickett !
================
Comment at: clang/test/Misc/target-invalid-cpu-note.c:27
// TUNE_X86_64: error: unknown target CPU 'not-a-cpu'
-// TUNE_X86_64: note: valid target CPU values are: i386, i486, winchip-c6,
winchip2, c3,
-// TUNE_X86_64-SAME: i586, pentium, pentium-mmx, pentiumpro, i686, pentium2,
pentium3,
-// TUNE_X86_64-SAME: pentium3m, pentium-m, c3-2, yonah, pentium4, pentium4m,
prescott,
-// TUNE_X86_64-SAME: nocona, core2, penryn, bonnell, atom, silvermont, slm,
goldmont, goldmont-plus, tremont,
-// TUNE_X86_64-SAME: nehalem, corei7, westmere, sandybridge, corei7-avx,
ivybridge,
-// TUNE_X86_64-SAME: core-avx-i, haswell, core-avx2, broadwell, skylake,
skylake-avx512,
-// TUNE_X86_64-SAME: skx, cascadelake, cooperlake, cannonlake, icelake-client,
rocketlake, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm,
lakemont, k6, k6-2, k6-3,
-// TUNE_X86_64-SAME: athlon, athlon-tbird, athlon-xp, athlon-mp, athlon-4, k8,
athlon64,
-// TUNE_X86_64-SAME: athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3,
amdfam10,
-// TUNE_X86_64-SAME: barcelona, btver1, btver2, bdver1, bdver2, bdver3,
bdver4, znver1, znver2, znver3,
-// TUNE_X86_64-SAME: x86-64, geode{{$}}
+// TUNE_X86_64-NEXT: note: valid target CPU values are: i386, i486,
winchip-c6, winchip2, c3, i586, pentium, pentium-mmx, pentiumpro, i686,
pentium2, pentium3, pentium3m, pentium-m, c3-2, yonah, pentium4, pentium4m,
prescott, nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont,
goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx,
ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512,
skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake,
icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, lakemont, k6,
k6-2, k6-3, athlon, athlon-tbird, athlon-xp, athlon-mp, athlon-4, k8, athlon64,
athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona,
btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64,
geode{{$}}
----------------
DavidSpickett wrote:
> This one uses `{{$}}` which I think (please check) means that anything extra
> on the end of the line will be a mistmatch. I'd add that to the rest as well.
Yes, you are right. When adding the {{$}}. I found two targets missing some
checks for cpus at the end of the line: NVPTX and HEXAGON. So adding this is
helpful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110798/new/
https://reviews.llvm.org/D110798
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
