kristof.beyls added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133 + + if (Triple.getVendor() != llvm::Triple::UnknownVendor) + return false; ---------------- MaskRay wrote: > Is vendor check necessary? I'm guessing that without the vendor check, triples aarch64-//anything//-elf would also be considered bare metal triples? Or would it be aarch64-none-//anything//-elf? I'm afraid I don't know the answer to the question on whether the vendor check should be removed or not. However, I think it's best for this patch to keep this as is to keep consistency with the arm and riscv bare metal targets in this file, which also have the same check for the triple vendor to be UnknownVendor. If it would be best to drop this check, it probably would be best to do it as a separate patch, and potentially make the change for the arm and riscv triples too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111134/new/ https://reviews.llvm.org/D111134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
