MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133 + + if (Triple.getVendor() != llvm::Triple::UnknownVendor) + return false; ---------------- Is vendor check necessary? ================ Comment at: clang/test/Driver/baremetal.cpp:105 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: -target aarch64-none-elf \ ---------------- You may follow the style in `linux-cross.cpp` and enumerate include paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111134/new/ https://reviews.llvm.org/D111134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
