aaron.ballman added inline comments.
================ Comment at: clang/lib/Parse/ParseTemplate.cpp:923 + // Skip until the semi-colon or a '}'. + SkipUntil(tok::r_brace, StopAtSemi | StopBeforeMatch); + TryConsumeToken(tok::semi); ---------------- erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > I'm not positive about this skip-until and 'TryConsumeToken' either. The > > > other place we do optional requires clause parsing does this, but the > > > above 'ParseTemplateParameters' does not. > > I think we should be skipping until we hit a `>` or `>>` rather than ` }` > > right? We can recover after we've finished the template template parameter > > parsing, we don't need to parse to the end of the class. > Perhaps we should copy line 1000 and skip until `>`, `>>` or `,` with no > consume? That's what I'm thinking, yes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
