erichkeane added a comment. In D110641#3028173 <https://reviews.llvm.org/D110641#3028173>, @aaron.ballman wrote:
> Btw, the CI failure for `x64 debian > Clang.SemaTemplate::concepts.cpp` looks > relevant. Not certain why I don't see a similar failure for Windows though. Looks like I miseed up the 'scope' of template-template parameters being usable in that requires clause there. I don't have a good idea of how to fix it, but looking into it. ================ Comment at: clang/lib/Parse/ParseTemplate.cpp:923 + // Skip until the semi-colon or a '}'. + SkipUntil(tok::r_brace, StopAtSemi | StopBeforeMatch); + TryConsumeToken(tok::semi); ---------------- I'm not positive about this skip-until and 'TryConsumeToken' either. The other place we do optional requires clause parsing does this, but the above 'ParseTemplateParameters' does not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
