erichkeane added inline comments.
================ Comment at: clang/include/clang/Basic/Attr.td:1690 +def NoUniqueAddress : InheritableAttr { let Spellings = [CXX11<"", "no_unique_address", 201803>]; let Subjects = SubjectList<[NonBitField], ErrorDiag>; ---------------- The way to do a `[[msvc::no_unique_address]]` is likely to create a new attribute here in Attr.td, then make the spelling be something like: `let Spellings = [CXX11<"msvc", "no_unique_address", N>];` Where `N` is a number that is the value of `__has_attribute` (which I note that MSVC has yet to implement?). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits