rmaz added a comment.
@vsapsai just checking on where we are with this one. Is the current plan to
investigate an approach only serializing the methods declared in each module,
or are we good to go ahead with the set de-duplication approach? I tried
profiling with D110123 <https://reviews.llvm.org/D110123> and with the
following patch:
diff --git a/clang/lib/Serialization/ASTReader.cpp
b/clang/lib/Serialization/ASTReader.cpp
index 279067a8ac8b..aaaca0aff9ab 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -8130,7 +8130,7 @@ namespace serialization {
FactoryBits = Data.FactoryBits;
InstanceHasMoreThanOneDecl = Data.InstanceHasMoreThanOneDecl;
FactoryHasMoreThanOneDecl = Data.FactoryHasMoreThanOneDecl;
- return true;
+ return false;
}
but this was a fair bit slower than the deduplication approach, and for some
files would never complete, presumably stuck in an infinite loop of dependent
modules. Is there a way to exclude the serialization of methods from dependent
modules but make the method lookup more efficient somehow?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109632/new/
https://reviews.llvm.org/D109632
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
